Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/57#discussion_r29941387
--- Diff:
jena-base/src/main/java/org/apache/jena/atlas/lib/CacheFactory.java ---
@@ -33,7 +33,7 @@
/** Create a null cache */
public static <Key, Value> Cache<Key, Value> createNullCache() {
- return new Cache0<>() ;
+ return new CacheGuava<>(0) ;
}
--- End diff --
Hm. There is one use of `Cache0`. It's indirectly, via `CacheFactory`, and
it occurs in `BlockMgrCache` at [line
62](https://github.com/apache/jena/blob/master/jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java#L62).
I'm not sure enough as to `BlockMgrCache`'s responsibilities to feel
comfortable rewiring it to not require the existence of a
`BlockMgrCache.readCache` without your go-ahead. I would feel better if I
better understood the comment "Caches are related so we can't use a Getter for
cache management." Does this refer to `readCache` and
`BlockMgrCache.writeCache`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
