Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/57#discussion_r29955075
--- Diff:
jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java ---
@@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots,
final BlockMgr blockMgr)
{
--- End diff --
I've made changes to `BlockMgrCache` sufficient to permit the removal of
`Cache0` from the codebase, but I'd much appreciate a careful review here.
Also, I have to admit I think this new code (with all the `null`-checks) to be
pretty ugly. I'd like to rewrite it using `Optional`, but I'd first like to be
sure that my basic understanding is correct.
P.S. Actually, I'd like to make `Cache::getIfPresent` return `Optional`.
That would really eliminate a lot of `null`-checking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
