[ 
https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558305#comment-15558305
 ] 

ASF GitHub Bot commented on JENA-576:
-------------------------------------

Github user ajs6f commented on a diff in the pull request:

    https://github.com/apache/jena/pull/151#discussion_r82505814
  
    --- Diff: 
jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java 
---
    @@ -135,8 +135,7 @@ private QueryEngineHTTP(String serviceURI, Query query, 
String queryString, Http
             this.query = query;
             this.queryString = queryString;
             this.service = serviceURI;
    -        // Copy the global context to freeze it.
    -        this.context = new Context(ARQ.getContext());
    +        this.context = ARQ.getContext();
    --- End diff --
    
    Turns out that there is already a `getContext()` on `QueryEngineHTTP`-- 
I'll just use that.


> Upgrade Apache HTTP Client to 4.3
> ---------------------------------
>
>                 Key: JENA-576
>                 URL: https://issues.apache.org/jira/browse/JENA-576
>             Project: Apache Jena
>          Issue Type: Dependency upgrade
>          Components: ARQ
>    Affects Versions: Jena 2.11.0
>            Reporter: Rob Vesse
>            Assignee: Rob Vesse
>            Priority: Minor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> As of 2.11.0 ARQ centralizes all HTTP operations through HttpOp which relies 
> on Apache HTTP Client.  Currently we are using 4.2.3 while the latest stable 
> release is actually 4.3.1
> Therefore we should look at upgrading our code to use the latest version 
> which may entail some refactoring since there appears to have been some 
> breaking changes across the minor version bump which users have seen in usage 
> - e.g. 
> https://github.com/pyvandenbussche/sparqles/issues/9#issuecomment-27220738



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to