On Mon, Feb 5, 2018 at 10:56 AM, Felix Schumacher < felix.schumac...@internetallee.de> wrote:
> Am 04.02.2018 20:43, schrieb Philippe Mouawad: > >> Hello, >> Following Felix feedback, I rollback my +1 vote. >> [-1] I do not support this release because: >> >> - I am afraid JMETER_HEAP will disturb users >> > > Are you afraid as HEAP is the name of the variable used for years and > might be known to users, or more > by the fact, that windows and unix name is (was) different? > By both in fact: - Old users might be disturbed - New users might be confused under windows > > Either way, we should probably rename (JMETER_)GC_ALGO, too. Thinking > about the usage of > JMETER_LANGUAGE could not hurt, either. > Yes > > - It is not clean that we use 2 different env variables >> - Same that mirror-server is broken >> - The warnings regarding Java 9 should also be dropped or a clear >> statement should be in documentation >> > > Was this addressed by your recent patches adding modules to JAVA9_OPTS? > The ones I am aware of, but I don't guarantee I spotted them all. This Java 9 migration is kind of nightmare > > Regards, > Felix > > - This might introduce issues: >> - https://github.com/oblac/jodd/issues/567 >> >> >> Would it be possible for next release to reduce the 72 hours or not ? >> >> Regards >> >> >> >> >> On Sun, Feb 4, 2018 at 8:10 PM, Milamber <milam...@apache.org> wrote: >> >> >>> >>> On 03/02/2018 19:11, Felix Schumacher wrote: >>> >>> Am 02.02.2018 um 16:33 schrieb Milamber: >>>> >>>> Hello, >>>>> >>>>> The sixth (oups) release candidate for JMeter 4.0 (r1822967) has been >>>>> prepared, and your votes are solicited. >>>>> >>>>> This release brings a new default theme (Darcula), support for Java 9, >>>>> 74 enhancements (new features and improvements), and 26 bug fixes. >>>>> >>>>> Please, test this release candidate (with load tests and/or functional >>>>> tests) using Java 8 or 9 on Linux/Windows/Mac OS, especially on the >>>>> changes. Feedback is very welcome within the next 72 hours. >>>>> >>>>> You can read the New and Noteworthy section with some screenshots to >>>>> illustrate improvements and full list of changes at: >>>>> http://home.apache.org/~milamber/jmeter-4.0RC6/docs/changes.html >>>>> >>>>> JMeter is a Java desktop application designed to load test functional >>>>> behavior and measure performance. The current version targets Java 8 / >>>>> 9. >>>>> >>>>> Download - Archives/hashes/sigs: >>>>> >>>>> https://dist.apache.org/repos/dist/dev/jmeter/v4.0_RC6/ >>>>> (dist revision r24640) >>>>> >>>>> RAT report: >>>>> >>>>> http://home.apache.org/~milamber/jmeter-4.0RC6/dist/rat- >>>>> report-jmeter-4.0RC6.txt >>>>> >>>>> MD5 hashes of archives for this vote: >>>>> >>>>> a497d140f1956ba65cf15930b0638333 *apache-jmeter-4.0.tgz >>>>> 8b7015e303b3aac83d1a050cb3782860 *apache-jmeter-4.0.zip >>>>> b3d9cce11b04be574a47b4108a3d2bc6 *apache-jmeter-4.0_src.tgz >>>>> 04dbd79c242192cdcde574e10c7c43cd *apache-jmeter-4.0_src.zip >>>>> >>>>> >>>>> Site Docs are here: >>>>> http://home.apache.org/~milamber/jmeter-4.0RC6/docs/ >>>>> >>>>> Maven staging repository is accessible here: >>>>> https://repository.apache.org/content/repositories/orgapache >>>>> jmeter-1027/org/apache/jmeter/ >>>>> >>>>> Tag: >>>>> https://svn.apache.org/repos/asf/jmeter/tags/v4_0_RC6/ >>>>> >>>>> Keys are here: >>>>> https://www.apache.org/dist/jmeter/KEYS >>>>> >>>>> N.B. >>>>> To download the dependencies: "ant download_jars" >>>>> >>>>> To create the jars and test JMeter: "ant package test". >>>>> >>>>> JMeter 4.0 requires Java 8 or later to run. >>>>> >>>>> Some known issues and incompatible changes are listed on changes page. >>>>> http://home.apache.org/~milamber/jmeter-4.0RC6/docs/changes. >>>>> html#Known%20problems%20and%20workarounds >>>>> >>>>> >>>>> All feedback and vote are welcome. >>>>> >>>>> [x] +1 I support this release >>>>> >>>>> >>>> I found three minor bugs: >>>> >>>> * in bin/mirror-server.*. Those scripts are referring to log4j 2.8.2 >>>> while we have 2.10.0 in the lib path. The mirror-server will not start >>>> with >>>> those values. >>>> >>>> * the HEAP variables in jmeter.sh and jmeter.bat are named differently >>>> (and are documented with their correct names), but JMeter prints out to >>>> modify JMETER_HEAP in the batch file. We should probably name those two >>>> variables (HEAP for batch and JMETER_HEAP for shell) the same. Apart >>>> from >>>> this the user should not edit the shell scripts, but place those >>>> variables >>>> into bin/setenv.* :) >>>> >>>> * to run ant test I have to unset the variables LANG and LC_*. >>>> Otherwise the tcp tests will fail as there are language dependent error >>>> messages embedded in the csv files that get compared. >>>> >>>> >>> >>> You continue with your +1 vote or you prefer apply a -1 vote (and go to a >>> new RC)? >>> >>> >>> >>> >>> Regards, >>>> Felix >>>> >>>> >>>> [ ] +0 I am OK with this release >>>> >>>>> [ ] -0 OK, but.... >>>>> [ ] -1 I do not support this release (please indicate why) >>>>> >>>>> The vote will remain open for at least 72 hours. >>>>> >>>>> The PMC members please indicate the mention "(binding)" with your vote. >>>>> >>>>> >>>>> Note: If the vote passes, the intention is to release the archive files >>>>> and rename the RC tag as the release tag. >>>>> >>>>> Thanks in advance! >>>>> >>>>> Milamber >>>>> >>>>> *Note:* the RC1, RC2 and RC3 were not submit for vote due an issue in >>>>> release process when the maven artefacts are upload to nexus. For this >>>>> RC6, >>>>> the automatic maven upload inside build.xml was replaced by a >>>>> semi-automatic upload with the maven-gpg-plugin. >>>>> >>>>> *Note2:* the RC5 were not submit for vote due an little commit by >>>>> Philippe :-) during the release process. >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>>> >>> -- Cordialement. Philippe Mouawad.
