wkurniawan07 opened a new pull request, #708:
URL: https://github.com/apache/jmeter/pull/708

   ## Description
   
   Add necessary fixes such that CI build can pass.
   
   Note that the solution I introduced, particularly for fixing the errorprone 
violations, are the ones requiring least amount of change, but not necessarily 
the most ideal:
   - [`InlineMeSuggester`](http://errorprone.info/docs/inlineme) are reported 
in almost all places where `@Deprecated` annotation is used, thus suppressed.
   - `JavaUtilDate` is suppressed, otherwise all instances of `Date` has to be 
replaced with `LocalDate` or `Instant`. Incidentally all places where the 
violations exist are annotated with `@SuppressWarnings("JdkObsolete")`.
   - For the charset-related fixes, I tried to look at what charsets are 
appropriate based on the file content, otherwise I fall back to `UTF8`.
   
   ## Motivation and Context
   
   I notice that the CI build of this project has not been passing for a while 
now, in particular due to the commit 7d2afdc5eca3b9d6847712f79730fcac4c8a99db. 
A non-passing CI build allowed in development branch can and will hide subtle 
(and not subtle) system bugs.
   
   ## How Has This Been Tested?
   
   Green tick in CI build.
   
   ## Types of changes
   
   - Bug fix (non-breaking change which fixes an issue)
   
   ## Checklist:
   
   - [x] My code follows the [code style][style-guide] of this project.
   - [x] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to