[GitHub] [jmeter] vlsi commented on a diff in pull request #708: Add necessary fixes for passing CI build

[GitBox]

vlsi commented on code in PR #708:
URL: https://github.com/apache/jmeter/pull/708#discussion_r848013952


##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/HttpRequestHdr.java:
##########
@@ -164,7 +164,7 @@ public byte[] parse(InputStream in) throws IOException {
                     inHeaders = false;
                     firstLine = false; // cannot be first line either
                 }
-                final String reqLine = line.toString();
+                final String reqLine = 
line.toString(Charset.defaultCharset().name());

Review Comment:
   Only ASCII is should be in the headers (see `CharUtils.isAscii` above), so 
this encoding should be like `StandardCharsets.ISO_8859_1`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org