vlsi commented on code in PR #708:
URL: https://github.com/apache/jmeter/pull/708#discussion_r848136633
##########
src/core/src/main/java/org/apache/jmeter/gui/action/HtmlReportGenerator.java:
##########
@@ -83,7 +84,7 @@ public List<String> run() {
LOGGER.debug("Running report generation");
resultCode = sc.run(generationCommand);
if (resultCode != 0) {
- errorMessageList.add(commandExecutionOutput.toString());
+
errorMessageList.add(commandExecutionOutput.toString(StandardCharsets.UTF_8.name()));
Review Comment:
Replacing `.toString()` with `.toString(...defaultCharset...)` is a step
forward to identifying the locations that rely on default charset. However, it
would be great if we can move towards UTF-8 since UTF-8 will be the default in
the upcoming Java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
