rmannibucau commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021605409
##########
pom.xml:
##########
@@ -164,16 +177,50 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${checkstyle.version}</version>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <!-- todo: migrate to spotbugs-maven-plugin as the findbugs plugin
is no longer maintained -->
+ <version>3.0.5</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-pmd-plugin</artifactId>
+ <version>3.19.0</version>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>versions-maven-plugin</artifactId>
+ <version>2.13.0</version>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>taglist-maven-plugin</artifactId>
+ <version>3.0.0</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-changelog-plugin</artifactId>
+ <version>2.3</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-changes-plugin</artifactId>
+ <version>2.12.1</version>
+ </plugin>
</plugins>
</pluginManagement>
+
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
- <source>${java-compile.version}</source>
Review Comment:
why? should stay in the project IMHO
##########
johnzon-osgi/pom.xml:
##########
@@ -29,6 +29,10 @@
<name>Johnzon :: Support for OSGI Jaxrs Whiteboard</name>
<packaging>bundle</packaging>
+ <properties>
+ <maven.javadoc.skip>true</maven.javadoc.skip>
Review Comment:
guess it will break the release no?
##########
johnzon-jsonb/src/test/java/org/apache/johnzon/jsonb/JsonbRecordTest.java:
##########
@@ -34,19 +34,19 @@ public class JsonbRecordTest {
@Test
public void roundTrip() {
- final Record ref = new Record(119, "Santa");
+ final JsonbRecord ref = new JsonbRecord(119, "Santa");
final String expectedJson = "{\"_name\":\"Santa\",\"age\":119}";
assertEquals(expectedJson, jsonb.toJson(ref));
- assertEquals(ref, jsonb.fromJson(expectedJson, Record.class));
+ assertEquals(ref, jsonb.fromJson(expectedJson, JsonbRecord.class));
}
@JohnzonRecord
- public static class Record {
+ public static class JsonbRecord {
Review Comment:
why was it needed?
##########
pom.xml:
##########
@@ -387,8 +433,7 @@
<detectJavaApiLink>false</detectJavaApiLink>
<detectLinks>false</detectLinks>
<detectOfflineLinks>false</detectOfflineLinks>
- <doclint>none</doclint>
- <source>8</source>
Review Comment:
source needed I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
