SingingBush commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021618768
##########
johnzon-jsonb/src/test/java/org/apache/johnzon/jsonb/JsonbRecordTest.java:
##########
@@ -34,19 +34,19 @@ public class JsonbRecordTest {
@Test
public void roundTrip() {
- final Record ref = new Record(119, "Santa");
+ final JsonbRecord ref = new JsonbRecord(119, "Santa");
final String expectedJson = "{\"_name\":\"Santa\",\"age\":119}";
assertEquals(expectedJson, jsonb.toJson(ref));
- assertEquals(ref, jsonb.fromJson(expectedJson, Record.class));
+ assertEquals(ref, jsonb.fromJson(expectedJson, JsonbRecord.class));
}
@JohnzonRecord
- public static class Record {
+ public static class JsonbRecord {
Review Comment:
I can revert that if needed. I felt that the 'Record' naming was a little to
close to the 'record' keyword
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
