SingingBush commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021627910
##########
.github/workflows/maven.yml:
##########
@@ -22,10 +22,7 @@ jobs:
distribution: ${{ matrix.dist }}
cache: 'maven'
- - name: Maven Package
+ - name: Maven Verify
env:
MAVEN_OPTS: -Dmaven.artifact.threads=64
- run: mvn -V package --no-transfer-progress
-
- #- name: Maven javadoc
- # run: mvn javadoc:javadoc -Ddoclint=all --no-transfer-progress
+ run: mvn -V verify --no-transfer-progress
Review Comment:
I thought verify was needed to ensure plugins like checkstyle and the
javadoc linting kick in. If they are running as part of package then it can be
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]