rmannibucau commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021625991
##########
johnzon-jsonb/src/test/java/org/apache/johnzon/jsonb/JsonbRecordTest.java:
##########
@@ -34,19 +34,19 @@ public class JsonbRecordTest {
@Test
public void roundTrip() {
- final Record ref = new Record(119, "Santa");
+ final JsonbRecord ref = new JsonbRecord(119, "Santa");
final String expectedJson = "{\"_name\":\"Santa\",\"age\":119}";
assertEquals(expectedJson, jsonb.toJson(ref));
- assertEquals(ref, jsonb.fromJson(expectedJson, Record.class));
+ assertEquals(ref, jsonb.fromJson(expectedJson, JsonbRecord.class));
}
@JohnzonRecord
- public static class Record {
+ public static class JsonbRecord {
Review Comment:
yes, was the intent - and to be honest it is not lowercase just to run well
on later java versions ;) - cause it is supposed to mimic a `record`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
