[ 
https://issues.apache.org/jira/browse/JSPWIKI-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135768#comment-18135768
 ] 

Arturo Bernal commented on JSPWIKI-90:
--------------------------------------

Two pull requests are open for this issue.

https://github.com/apache/jspwiki/pull/565 sends an e-mail to the users 
subscribed to a page when the page changes. The mail is sent from the listener 
of the save of a page, as discussed in 2009 in this issue; nothing is polled. 
When nobody is subscribed to the page, the save does not read or render the 
page.

https://github.com/apache/jspwiki/pull/566 builds on the first one and adds the 
menu entry to be notified of the changes of a page, and lets the editor 
subscribe the user to the page it saves.

The tests of both pull requests pass locally, and the checks of GitHub Actions 
(Linux, macOS and Windows, Java 17 and 21) are green on both, after fixing a 
failure of DefaultPageManagerTest.testDeleteVersion that the first version of 
the change caused on Windows and on Java 21.

Not tried: unsubscribing and then saving, saving with the box unchecked, and 
the notifications for comments added with Comment.jsp. The code of the plugin 
Ulf attached was not used. Ulf, if you can, please review the pull requests.

> Mail notification on changes or new comments
> --------------------------------------------
>
>                 Key: JSPWIKI-90
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-90
>             Project: JSPWiki
>          Issue Type: Wish
>          Components: Core & storage
>    Affects Versions: 2.5.139-beta
>            Reporter: Jürgen Weber
>            Assignee: Janne Jalkanen
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: EmailNotifierPlugin.java, emailnotifier.zip, 
> notification-configfile.properties
>
>
> There should be eMail notification on changes or new comments for authors and 
> people who wish to be cced, same as in Bugzilla.
> A page would have a list of users to notify for changes.
> In the "more.." menu could be an "notify me for changes", same with a 
> checkbox for the new page dialog.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to