Hi PoAn, Thanks for the KIP.
I have two uneducated questions based regarding expected usage by the client layer: KT1. Can you elaborate on the statement from the Motivation section, "However, we don't fully utilized this approach?" Is "we" the Kafka project's internals, or the community? KT2. Is the intention that the client layer will still use Endpoint? If so, the new listener() method will return null, yes? My concern is that developers of the client will lose the Optional safeguard with this change. Not to bike shed, but, IMO, "listenerName()" is the more accurate method name, given its purpose, but I guess it's harder to change the method return type of an existing method than to introduce a new method. Thanks, Kirk On Mon, Mar 24, 2025, at 7:17 AM, Chia-Ping Tsai wrote: > hi PoAn > > Have you consider aligning the naming of `RaftVoterEndpoint`? i.e deprecate > `name()` and add `listener()` for consistency. > > Best, > Chia-Ping > > On 2025/03/16 12:52:42 PoAn Yang wrote: > > Hi all, > > > > I would like to start a discussion thread on KIP-1143. > > > > This KIP removes redundant org.apache.kafka.network.EndPoint and replaces > > it with org.apache.kafka.common.Endpoint. Also, it changes output of > > Endpoint#listenerName from Optional<String> to String. > > > > Please take a look and feel free to share any thoughts. > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=345377327 > > > > Sample PR: https://github.com/apache/kafka/pull/19191 > > > > Thanks, > > PoAn >
