Hi Kirk and Chia-Ping, Thanks for the review.
KT1: Update Motivation section to elaborate more on why we want to deprecated Optional<String> function in common Endpoint. KT2: Like Chia-Ping mentioned, the only usage of common Endpoint in client module is Authorizer and the data is from server side, so the listener name cannot be null. If there is no further discussion, I will start voting thread tomorrow. Thanks. Best, PoAn > On Mar 25, 2025, at 4:16 PM, Chia-Ping Tsai <chia7...@apache.org> wrote: > > hi Kirk > >> KT2. Is the intention that the client layer will still use Endpoint? If so, >> the new listener() method will return null, yes? My concern is that >> developers of the client will lose the Optional safeguard with this change. > > Given that the client layer utilizes org.apache.kafka.common.Endpoint within > the Authorizer, the endpoint object supplied to the Authorizer must never > contain a null listener. > > Best, > Chia-Ping > >
