2016-10-13 11:28 GMT+02:00 Achim Nierbeck <bcanh...@googlemail.com>:

> Just one question,
> what's the effect on already existing Karaf commands and those completions
> etc.
> If that is not affected at all I've got no complaints ;)
>

Existing commands are not affected.

To achieve the above, I'm using a completer which delegate to both the
completer for karaf commands and the gogo-jline completer.
One change in jline3 made that easy, as jline3 completers do not have to
filter the completions, and jline will filter non matching completion
candidates itself.  In particular, this allow to do typos corrections ;-)

That said, I think we should get rid of duplicated commands, such as the
posix / procedural ones (each, if, grep, less, etc...) and the ones that
are provided by projects directly such as the scr commands.


>
> regards, Achim
>
>
> 2016-10-12 18:41 GMT+02:00 Guillaume Nodet <gno...@apache.org>:
>
> > The problem is to obtain the list of scripts that needs to be loaded
> > somehow.
> > If we somehow include (using the source command for example), it means we
> > need to copy the script file *and* modify another script, which may be a
> > bit more complicated than necessary.
> >
> > 2016-10-12 18:38 GMT+02:00 Jean-Baptiste Onofré <j...@nanthrax.net>:
> >
> > > Hi Guillaume,
> > >
> > > what about a etc/gosh_profilerc that can load other scripts ?
> > >
> > > Regards
> > > JB
> > >
> > >
> > > On 10/12/2016 05:57 PM, Guillaume Nodet wrote:
> > >
> > >> I'm working on trying to nicely integrate gogo commands.
> > >> The new gogo-jline bundle has a very nice way to allow external
> > >> configuration for command completion. For example, one need to execute
> > the
> > >> script at https://gist.github.com/gnodet/
> 18de68d57fc959efb7f9e4766415ff
> > 5e
> > >> to add full completion to the Karaf shell once you have the scr bundle
> > >> installed (it always provides gogo commands).  Other examples are
> > >> available
> > >> at
> > >> https://github.com/apache/felix/blob/trunk/gogo/jline/src/
> > >> main/resources/gosh_profile
> > >>
> > >> The question is : how to provide such a script.
> > >> One possibility would be to have a dedicated folder such as
> etc/scripts/
> > >> where all scripts would be loaded when a session is started. We could
> > then
> > >> reference those files in features so that they are copied when
> features
> > >> are
> > >> installed.
> > >> This would allow leveraging the <configfile> feature xml element.
> > >>
> > >> Do you guys have better ideas ?
> > >>
> > >>
> > > --
> > > Jean-Baptiste Onofré
> > > jbono...@apache.org
> > > http://blog.nanthrax.net
> > > Talend - http://www.talend.com
> > >
> >
> >
> >
> > --
> > ------------------------
> > Guillaume Nodet
> > ------------------------
> > Red Hat, Open Source Integration
> >
> > Email: gno...@redhat.com
> > Web: http://fusesource.com
> > Blog: http://gnodet.blogspot.com/
> >
>
>
>
> --
>
> Apache Member
> Apache Karaf <http://karaf.apache.org/> Committer & PMC
> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer &
> Project Lead
> blog <http://notizblog.nierbeck.de/>
> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>
>
> Software Architect / Project Manager / Scrum Master
>



-- 
------------------------
Guillaume Nodet
------------------------
Red Hat, Open Source Integration

Email: gno...@redhat.com
Web: http://fusesource.com
Blog: http://gnodet.blogspot.com/

Reply via email to