[
https://issues.apache.org/jira/browse/KNOX-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478516#comment-15478516
]
Larry McCay commented on KNOX-732:
----------------------------------
Hi [~smore] - thanks for the patch!
In the code below can you describe what the wrapping of the correlationHandler
is for?
I think that the correlationHandler is supposed to wrap other handlers and make
the request correlationId available to them.
{code}
/* KNOX-732: Handler for GZip compression */
GzipHandler gzipHandler = new GzipHandler();
gzipHandler.addIncludedMimeTypes("text/html", "text/plain", "text/xml",
"text/css", "application/javascript", "text/javascript");
gzipHandler.setHandler(correlationHandler);
{code}
Unless I am missing something there, we should remove that line and I'll do
some manual testing of your fix.
Thanks again!
> Knox does not recompress javascript resources
> ---------------------------------------------
>
> Key: KNOX-732
> URL: https://issues.apache.org/jira/browse/KNOX-732
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.10.0
> Reporter: Sumit Gupta
> Assignee: Sandeep More
> Fix For: 0.10.0
>
> Attachments: KNOX-732.001.patch, KNOX-732.002.patch
>
>
> When using the Ambari UI proxy service it is observed that the app.js file is
> about 7MB whereas it is much smaller (about 1MB) when the UI is not proxied
> by Knox.
> A compression solution needs to be investigated. Possibly by adding a gzip
> compression handler or filter to jetty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
