[
https://issues.apache.org/jira/browse/KNOX-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078340#comment-16078340
]
Sandeep More commented on KNOX-843:
-----------------------------------
Hello [~jeffreyr97] The patch looks good, I did not test it though, following
are some of my observations
* Name of the property "HaActive" does not follow the standard used for other
properties e.g. maxFailoverAttempts, failoverSleep etc. it could be "haActive"
* DefaultHaDispatch.java -> #182 -> Let's not eat the URISyntaxException
* HaDescriptorFactory.java -> #51 why is haActiveValue string array when we
just need a boolean value ?
* DefaultHaDispatchTest.java -> What does the newly added test
testConnectivityActive, test ?
* HaProvider.java -> #74 the method name looks a bit confusing, could be
something like nextAvailable(). Also the java docs looks incomplete and there
are some extra params in javadocs (url) which are not used.
* Do we have a test for LB and Session affinity ?
Let me know your thoughts.
Thanks !
> Add support for load balancing across HA instances
> --------------------------------------------------
>
> Key: KNOX-843
> URL: https://issues.apache.org/jira/browse/KNOX-843
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Affects Versions: 0.11.0
> Reporter: Sam Hjelmfelt
> Assignee: Jeffrey E Rodriguez
> Fix For: 0.13.0
>
> Attachments: KNOX-843.001.patch, KNOX-843.002.patch, KNOX-843.patch,
> KNOX-843.pdf
>
>
> Knox should support load balancing across HA service instances rather than
> just offering failover.
> One solution may be to add an option to the HAProvider.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
