[
https://issues.apache.org/jira/browse/KNOX-2961?focusedWorklogId=883004&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883004
]
ASF GitHub Bot logged work on KNOX-2961:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/23 21:37
Start Date: 02/Oct/23 21:37
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #797:
URL: https://github.com/apache/knox/pull/797#discussion_r1343190787
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java:
##########
@@ -350,11 +350,12 @@ private String getTimestampDisplay(long timestamp) {
}
/**
- * Method that deletes expired tokens based on the token timestamp.
+ * Method that deletes expired tokens based on the token timestamp as well
as disabled KnoxSSO cookies.
*/
protected void evictExpiredTokens() {
if (readyForEviction()) {
final Set<String> tokensToEvict = getExpiredTokens();
+ tokensToEvict.addAll(getDisabledKnoxSsoCookies());
Review Comment:
Hmm...this seems to be not needed; I'll conduct another test round tomorrow
morning.
Issue Time Tracking
-------------------
Worklog Id: (was: 883004)
Time Spent: 1h 20m (was: 1h 10m)
> KnoxSSO Token Invalidation
> --------------------------
>
> Key: KNOX-2961
> URL: https://issues.apache.org/jira/browse/KNOX-2961
> Project: Apache Knox
> Issue Type: New Feature
> Components: KnoxSSO, Server, TokenManagementUI
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> There is a need for a new feature that would allow a pre-configured superuser
> to invalidate previously issued Knox SSO tokens for (a) particular user(s) in
> case there is a malicious attack in terms of one (or more) of those users'
> SSO tokens got compromised.
> In phase I, the following changes have to be implemented:
> - Knox SSO cookie validation using PAM, LDAP, and Pac4j
> authentication/federation
> - The token Management page should be updated in a way such that it'll
> contain only one compact table with all the information we need of a
> generated token (is impersonated, is Knox SSO cookie, available actions)
> - Knox SSO cookies on the new token management UI can be disabled
> (invalidated), but not revoked.
> - Disabled KnoxSSO cookies should be removed from the underlying token state
> service within the configure eviction period even if they were not expired
> In phase II, the token management page should be updated with the following
> improvements:
> * pre-configured superusers can view tokens of others and not only theirs
> * batch operations should be able to be executed using the available actions
> to make it easier for a superuser to disable one's tokens in a round
--
This message was sent by Atlassian Jira
(v8.20.10#820010)