[ 
https://issues.apache.org/jira/browse/KNOX-2961?focusedWorklogId=884002&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-884002
 ]

ASF GitHub Bot logged work on KNOX-2961:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Oct/23 09:40
            Start Date: 09/Oct/23 09:40
    Worklog Time Spent: 10m 
      Work Description: zeroflag commented on code in PR #799:
URL: https://github.com/apache/knox/pull/799#discussion_r1350073117


##########
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java:
##########
@@ -559,6 +569,22 @@ public Response renew(String token) {
     return resp;
   }
 
+  @DELETE
+  @Path(BATCH_REVOKE_PATH)
+  @Produces({APPLICATION_JSON})
+  public Response revokeTokens(String tokenIds) {
+    final List<String> ids = GSON.fromJson(tokenIds, List.class);

Review Comment:
   Hmm, I remember there was some arguments whether DELETE requests are allowed 
to have request bodies or not. Maybe the frameworks think it's not allowed 
therefore it rejects it.
   
   I found this:
   
   ```
   There is nothing in the specifications that prohibits the use of a body for 
a HTTP Delete request. However for some HTTP clients this may not be 
implemented and some servers may ignore it, work incorrectly or refuse the 
request.
   ```
   
   Does it work in all major web browsers?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 884002)
    Time Spent: 2h 50m  (was: 2h 40m)

> KnoxSSO Token Invalidation
> --------------------------
>
>                 Key: KNOX-2961
>                 URL: https://issues.apache.org/jira/browse/KNOX-2961
>             Project: Apache Knox
>          Issue Type: New Feature
>          Components: KnoxSSO, Server, TokenManagementUI
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Major
>             Fix For: 2.1.0
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> There is a need for a new feature that would allow a pre-configured superuser 
> to invalidate previously issued Knox SSO tokens for (a) particular user(s) in 
> case there is a malicious attack in terms of one (or more) of those users' 
> SSO tokens got compromised.
> In phase I, the following changes have to be implemented:
>  - Knox SSO cookie validation using PAM, LDAP, and Pac4j 
> authentication/federation
>  - The token Management page should be updated in a way such that it'll 
> contain only one compact table with all the information we need of a 
> generated token (is impersonated, is Knox SSO cookie, available actions)
>  - Knox SSO cookies on the new token management UI can be disabled 
> (invalidated), but not revoked.
>  - Disabled KnoxSSO cookies should be removed from the underlying token state 
> service within the configure eviction period even if they were not expired
> In phase II, the token management page should be updated with the following 
> improvements:
>  * pre-configured superusers can view tokens of others and not only theirs
>  * batch operations should be able to be executed using the available actions 
> to make it easier for a superuser to disable one's tokens in a round



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to