[ 
https://issues.apache.org/jira/browse/KNOX-2961?focusedWorklogId=883038&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883038
 ]

ASF GitHub Bot logged work on KNOX-2961:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Oct/23 06:27
            Start Date: 03/Oct/23 06:27
    Worklog Time Spent: 10m 
      Work Description: smolnar82 commented on code in PR #797:
URL: https://github.com/apache/knox/pull/797#discussion_r1343562115


##########
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/JDBCTokenStateService.java:
##########
@@ -224,6 +224,19 @@ protected void evictExpiredTokens() {
     } catch (SQLException e) {
       log.errorRemovingTokensFromDatabase(e.getMessage(), e);
     }
+
+    //removing disabled KnoxSSO cookies since they are no longer needed
+    try {
+      final Set<String> disabledKnoxSsoCookies = 
tokenDatabase.getDisabledKnoxSsoCookies();
+      if (!disabledKnoxSsoCookies.isEmpty()) {
+        
log.removingDisabledKnoxSsoCookiesFromDatabase(disabledKnoxSsoCookies.size(),
+            String.join(", ", disabledKnoxSsoCookies.stream().map(tokenId -> 
Tokens.getTokenIDDisplayText(tokenId)).collect(Collectors.toSet())));
+        final int numOfRemovedDisabledKnoxSsoCookies = 
tokenDatabase.deleteDisabledKnoxSsoCookies();

Review Comment:
   I removed that method anyway.



##########
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/TokenStateDatabase.java:
##########
@@ -58,6 +58,9 @@ public class TokenStateDatabase {
   private static final String GET_TOKENS_CREATED_BY_USER_NAME_SQL = "SELECT 
kt.token_id, kt.issue_time, kt.expiration, kt.max_lifetime, ktm.md_name, 
ktm.md_value FROM " + TOKENS_TABLE_NAME
       + " kt, " + TOKEN_METADATA_TABLE_NAME + " ktm WHERE kt.token_id = 
ktm.token_id AND kt.token_id IN (SELECT token_id FROM " + 
TOKEN_METADATA_TABLE_NAME + " WHERE md_name = '" + TokenMetadata.CREATED_BY + 
"' AND md_value = ? )"
       + " ORDER BY kt.issue_time";
+  private static final String GET_DISABLED_SSO_COOKIE_TOKEN_IDS = "SELECT 
token_id FROM " + TOKEN_METADATA_TABLE_NAME + " meta1 WHERE meta1.md_name = 
'knoxSSOCookie' AND meta1.md_value = 'true' "
+      + "AND EXISTS (SELECT token_id FROM " + TOKEN_METADATA_TABLE_NAME + " 
meta2 WHERE meta1.token_id = meta2.token_id AND meta2.md_name = 'enabled' AND 
meta2.md_value = 'false')";
+  private static final String REMOVE_DISBLED_SSO_COOKIES_SQL = "DELETE FROM " 
+ TOKENS_TABLE_NAME + " WHERE token_id IN (" + 
GET_DISABLED_SSO_COOKIE_TOKEN_IDS + ")";

Review Comment:
   Removed.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 883038)
    Time Spent: 1.5h  (was: 1h 20m)

> KnoxSSO Token Invalidation
> --------------------------
>
>                 Key: KNOX-2961
>                 URL: https://issues.apache.org/jira/browse/KNOX-2961
>             Project: Apache Knox
>          Issue Type: New Feature
>          Components: KnoxSSO, Server, TokenManagementUI
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Major
>             Fix For: 2.1.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> There is a need for a new feature that would allow a pre-configured superuser 
> to invalidate previously issued Knox SSO tokens for (a) particular user(s) in 
> case there is a malicious attack in terms of one (or more) of those users' 
> SSO tokens got compromised.
> In phase I, the following changes have to be implemented:
>  - Knox SSO cookie validation using PAM, LDAP, and Pac4j 
> authentication/federation
>  - The token Management page should be updated in a way such that it'll 
> contain only one compact table with all the information we need of a 
> generated token (is impersonated, is Knox SSO cookie, available actions)
>  - Knox SSO cookies on the new token management UI can be disabled 
> (invalidated), but not revoked.
>  - Disabled KnoxSSO cookies should be removed from the underlying token state 
> service within the configure eviction period even if they were not expired
> In phase II, the token management page should be updated with the following 
> improvements:
>  * pre-configured superusers can view tokens of others and not only theirs
>  * batch operations should be able to be executed using the available actions 
> to make it easier for a superuser to disable one's tokens in a round



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to