[
https://issues.apache.org/jira/browse/KNOX-2961?focusedWorklogId=884000&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-884000
]
ASF GitHub Bot logged work on KNOX-2961:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/23 09:35
Start Date: 09/Oct/23 09:35
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #799:
URL: https://github.com/apache/knox/pull/799#discussion_r1350062612
##########
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java:
##########
@@ -559,6 +569,22 @@ public Response renew(String token) {
return resp;
}
+ @DELETE
+ @Path(BATCH_REVOKE_PATH)
+ @Produces({APPLICATION_JSON})
+ public Response revokeTokens(String tokenIds) {
+ final List<String> ids = GSON.fromJson(tokenIds, List.class);
Review Comment:
I thought the same way, however, I could not make it work this way:
```
@DELETE
@Path(BATCH_REVOKE_PATH)
@Produces({APPLICATION_JSON})
@Consumes({APPLICATION_JSON})
public Response revokeTokens(List<String> tokenIds) {
}
```
I always received 415 (Unsupported Media Type) every time no matter what I
tried (added the required headers in the `curl` command).
Issue Time Tracking
-------------------
Worklog Id: (was: 884000)
Time Spent: 2h 40m (was: 2.5h)
> KnoxSSO Token Invalidation
> --------------------------
>
> Key: KNOX-2961
> URL: https://issues.apache.org/jira/browse/KNOX-2961
> Project: Apache Knox
> Issue Type: New Feature
> Components: KnoxSSO, Server, TokenManagementUI
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> There is a need for a new feature that would allow a pre-configured superuser
> to invalidate previously issued Knox SSO tokens for (a) particular user(s) in
> case there is a malicious attack in terms of one (or more) of those users'
> SSO tokens got compromised.
> In phase I, the following changes have to be implemented:
> - Knox SSO cookie validation using PAM, LDAP, and Pac4j
> authentication/federation
> - The token Management page should be updated in a way such that it'll
> contain only one compact table with all the information we need of a
> generated token (is impersonated, is Knox SSO cookie, available actions)
> - Knox SSO cookies on the new token management UI can be disabled
> (invalidated), but not revoked.
> - Disabled KnoxSSO cookies should be removed from the underlying token state
> service within the configure eviction period even if they were not expired
> In phase II, the token management page should be updated with the following
> improvements:
> * pre-configured superusers can view tokens of others and not only theirs
> * batch operations should be able to be executed using the available actions
> to make it easier for a superuser to disable one's tokens in a round
--
This message was sent by Atlassian Jira
(v8.20.10#820010)