Dan Burkert has posted comments on this change. Change subject: [java client] Allow scanners to have projections with out-of-order keys ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3015/1/java/kudu-client/src/main/java/org/kududb/ColumnSchema.java File java/kudu-client/src/main/java/org/kududb/ColumnSchema.java: Line 109: public ColumnSchema getStrippedColumnSchema() { could this be package private? I can't see a reason for it to be in the public API. http://gerrit.cloudera.org:8080/#/c/3015/1/java/kudu-client/src/main/java/org/kududb/Schema.java File java/kudu-client/src/main/java/org/kududb/Schema.java: Line 238 This deserves a breaking change notice http://gerrit.cloudera.org:8080/#/c/3015/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java: Line 316: if (originalColumn == null) { this can't happen. Line 326: if (originalColumn == null) { this can't happen. -- To view, visit http://gerrit.cloudera.org:8080/3015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550cb255460bb54815d3a30eb973f8c143573e62 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
