Adar Dembo has posted comments on this change. Change subject: [java client] Allow scanners to have projections with out-of-order keys ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3015/2/java/kudu-client/src/main/java/org/kududb/ColumnSchema.java File java/kudu-client/src/main/java/org/kududb/ColumnSchema.java: Line 105: Get a new column schema instance that's based on this instance but stripped away from all its : * information except for its name, type, and nullability. Nit: wording is a bit weird. How about: Clone this column schema instance. The new instance will include only a name, type, and nullability. Line 107: * @return a new column schema that only has this instance's name, type, and nullability Nit: don't bother listing the three things the instance will have again; it's just another place to update when three things becomes four (or two, or whatever). Line 109: public ColumnSchema getStrippedColumnSchema() { > does this need to be part of the public API? This is a public class, so if +1 to what Todd said. http://gerrit.cloudera.org:8080/#/c/3015/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java: Line 316: columns.add(originalColumn.getStrippedColumnSchema()); Why is it important to use "stripped" variants here? -- To view, visit http://gerrit.cloudera.org:8080/3015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550cb255460bb54815d3a30eb973f8c143573e62 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
