Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Allow scanners to have projections with out-of-order keys ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3015/2/java/kudu-client/src/main/java/org/kududb/ColumnSchema.java File java/kudu-client/src/main/java/org/kududb/ColumnSchema.java: Line 109: public ColumnSchema getStrippedColumnSchema() { > +1 to what Todd said. I can't make it package-private, so I think I'll just make it a helper function somewhere. http://gerrit.cloudera.org:8080/#/c/3015/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java: Line 316: columns.add(originalColumn.getStrippedColumnSchema()); > Why is it important to use "stripped" variants here? Server-side gets confused otherwise. For example, passing the column schemas from the table's full schema and putting the column keys last in the projection, you'd get an error back. But passing the column schema with just the name, type, and nullability is fine. -- To view, visit http://gerrit.cloudera.org:8080/3015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550cb255460bb54815d3a30eb973f8c143573e62 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
