Todd Lipcon has posted comments on this change.

Change subject: [java client] Allow scanners to have projections with 
out-of-order keys
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3015/2/java/kudu-client/src/main/java/org/kududb/ColumnSchema.java
File java/kudu-client/src/main/java/org/kududb/ColumnSchema.java:

Line 109:   public ColumnSchema getStrippedColumnSchema() {
does this need to be part of the public API? This is a public class, so if we 
don't think it's going to be useful to clients we should try to hide it.


-- 
To view, visit http://gerrit.cloudera.org:8080/3015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I550cb255460bb54815d3a30eb973f8c143573e62
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to