Adar Dembo has posted comments on this change. Change subject: [java client] Allow scanners to have projections with out-of-order keys ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3015/3/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java: Line 352: private ColumnSchema getStrippedColumnSchema(ColumnSchema columnToClone) { Nit: can be static, right? I don't see it using any local state. -- To view, visit http://gerrit.cloudera.org:8080/3015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550cb255460bb54815d3a30eb973f8c143573e62 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
