Hi Hristo,

On Tue, Nov 15, 2005 at 17:21:26 +0200, Hristo Simenov Hristov wrote:

> (http://qa.openoffice.org/issues/show_bug.cgi?id=42198). It works, I tried 
> with own build, but there is a little problem. The numberings do not appear 
> in Options tab of Bullets and Numbering dialog, but only in Numbering tab 
> (after proper changes in the local xml file).

I _assume_ (unverified) it is because you defined non-ASCII content for
aSupportedTypes.cSymbol in

+        {style::NumberingType::CHARS_BG_CYRILLIC_UPPER_LETTER,      "А", 
LANG_ALL},

and following, and the makeNumberingIdentifier() method uses it in
    return OUString::createFromAscii(aSupportedTypes[index].cSymbol);

Try if setting the table entry to NULL instead shows at least two
entries. There would be no visible distinction between A,... and AAA,...
though, for this to work the OUString::createFromAscii(cSymbol) would
had to be replaced by a call creating an OUString from an UTF-8 encoded
literal, i.e.
OUString( cSymbol, sizeof(cSymbol)-1, RTL_TEXTENCODING_UTF8)

Note that character string constants can't contain 8-bit values for
portability reasons, so 8-bit UTF-8 values must be inserted using the
escaped hex \x12 or octal \012 notation.

Btw, I assume your change isn't only for Bulgarian Cyrillic, but also
would apply to general Cyrillic numbering, or am I wrong? If it's
a general Cyrillic alphabet numbering please remove the BG from the
identifiers and constants.

Some words on style: please adapt to the style found in a file, even if
"unusual", for example, instead of bgCyrUpperLetter use
table_CyrillicUpperLetter or such. Furthermore, don't use hardcoded
constants when there are better ways to let the compiler compute the
value during compile time, instead of

    lcl_formatChars( bgCyrUpperLetter, 30, number-1, result );

better use

     lcl_formatChars( bgCyrUpperLetter, sizeof(bgCyrUpperLetter) / 
sizeof(bgCyrUpperLetter[0]), number - 1, result);

This way the number of elements passed is always correct, even if
changed in the table.

Thanks
  Eike

-- 
 OOo/SO Calc core developer. Number formatter bedevilled i18n transpositionizer.
 GnuPG key 0x293C05FD:  997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to