----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42070/#review113673 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java (lines 188 - 195) <https://reviews.apache.org/r/42070/#comment174426> Why is additional loop required? lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java (lines 197 - 198) <https://reviews.apache.org/r/42070/#comment174425> whereAST will be usually common for all facts. The TODO here can be removed. lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java (line 200) <https://reviews.apache.org/r/42070/#comment174427> Comment needs update if havingAST is getitng update elsewhere. lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 891) <https://reviews.apache.org/r/42070/#comment174428> Why is having clause converted to where? lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java (lines 363 - 374) <https://reviews.apache.org/r/42070/#comment174429> Having clauses should be pushed down to corresponding fact queries. Should not be converted to where clause. - Amareshwari Sriramadasu On Jan. 8, 2016, 1:26 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42070/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 1:26 p.m.) > > > Review request for lens. > > > Bugs: LENS-813 > https://issues.apache.org/jira/browse/LENS-813 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensClient.java > f7f99c7c20b97e9f2b53c39ee147d5cc682f93dc > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > c305244c98ff38a0acaa24812ccec9d2910e0095 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 1fd1d17bbc05b2ca07d88237b4143ea3cd904d0e > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 26514d86776ff55f5a674ae51d1066100e797e10 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > bfb65c7bde8f6d9ec963714cf1cb9e292ed3ae9c > lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java > 1a729f8eab5cb3f8ab2eeb9bf32dc0c3efc05620 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > ac5632823d8a55f7e25b5058167e40fc7e6aedaf > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 5b44f9581ab1d57239b86738963ff519c0e94a9a > > Diff: https://reviews.apache.org/r/42070/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
