> On Jan. 11, 2016, 10:01 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java, > > lines 363-374 > > <https://reviews.apache.org/r/42070/diff/1/?file=1187464#file1187464line363> > > > > Having clauses should be pushed down to corresponding fact queries. > > Should not be converted to where clause. > > Rajat Khandelwal wrote: > Right now we have correctness issue. Push down of having clause has > certain requirements: > > 1. The entire boolean expression of having clause should be a bunch of > sub-clauses being `AND`ed together. > 2. Each of those sub-clauses should be completely evaluable by one of the > facts. '' > > Hence I've implemented a `correct` solution first, will take pushdown as > an improvement.
I've added pushdown feature. Now, first push down is tried, if not possible of some parts of the clause, then it's converted to outer where while adding components to select expressions of inner sub-queries. > On Jan. 11, 2016, 10:01 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, > > line 893 > > <https://reviews.apache.org/r/42070/diff/1/?file=1187459#file1187459line893> > > > > Why is having clause converted to where? > > Rajat Khandelwal wrote: > Because aggregation is already done. Inner having conditions have to be > written as where conditions in the outer query. This is now only the not-push-downable having clauses. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42070/#review113673 ----------------------------------------------------------- On Jan. 25, 2016, 6:21 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42070/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 6:21 p.m.) > > > Review request for lens. > > > Bugs: LENS-813 > https://issues.apache.org/jira/browse/LENS-813 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf > 9087fcd09f67c462c68f5385a58360bb8a16374b > lens-client/src/main/java/org/apache/lens/client/LensClient.java > f7f99c7c20b97e9f2b53c39ee147d5cc682f93dc > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 61d08b2769deb554eb3dc2d992b7a6b8ba3484b8 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasDecider.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > c305244c98ff38a0acaa24812ccec9d2910e0095 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 3e930ded95b5b975373d1035be61bf8360a45807 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultAliasDecider.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 5ff265db155363938f3b657256bb232056e50f78 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > b1deb0753fe36d2908ed4c8a98178a93644fab64 > lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java > 1a729f8eab5cb3f8ab2eeb9bf32dc0c3efc05620 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 7e3a0bfa703d27f38c5b2a5935d7d2da07125b7c > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 100d7c9cceb5feb98c5e88a688e364298d6543be > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 57a15e23a39cf09e1f167740083b43bb154334eb > > Diff: https://reviews.apache.org/r/42070/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
