> On Jan. 13, 2016, 12:59 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, > > line 58 > > <https://reviews.apache.org/r/42022/diff/2/?file=1186196#file1186196line58> > > > > Why are we creating static client? Please add comments.
The util needs to know whether a table is a cube table or not. For that `CubeMetastoreClient` instance is required. Hence created a static client for the entire utility to use. > On Jan. 13, 2016, 12:59 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, > > line 63 > > <https://reviews.apache.org/r/42022/diff/2/?file=1186196#file1186196line63> > > > > why are we creating a new HiveConf(), it may not talk to the correct > > metastore. will pass query's hiveconf to get instance. > On Jan. 13, 2016, 12:59 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, > > line 134 > > <https://reviews.apache.org/r/42022/diff/2/?file=1186196#file1186196line134> > > > > Can you check this with Hive 2.1 and see if we have to remove > > isCubeNode fully ? Yes. As in we don't *need* to remove it, but the function will never return true with Hive >= 2.1 - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42022/#review114156 ----------------------------------------------------------- On Jan. 7, 2016, 4:36 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42022/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 4:36 p.m.) > > > Review request for lens. > > > Bugs: LENS-912 > https://issues.apache.org/jira/browse/LENS-912 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e7550ca2c8307cba086e848e8b476a670366f7a5 > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java > abec2b338e0da6b56934a02d16c48a6a7917845a > lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java > 202db822f41fc53e6dad8789d6cac62a8c9be68c > > Diff: https://reviews.apache.org/r/42022/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
