> On Jan. 19, 2016, 11:45 a.m., Amareshwari Sriramadasu wrote: > > Can you run examples with the changes and update ?
Yes, have run. 148/148 succeeded. In fact, some of the test cases are inspired by examples. Some cases were not getting covered in tests but were getting covered in examples. :) - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42022/#review115115 ----------------------------------------------------------- On Jan. 18, 2016, 11:44 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42022/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 11:44 a.m.) > > > Review request for lens. > > > Bugs: LENS-912 > https://issues.apache.org/jira/browse/LENS-912 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java > 91cbe391a2bc81edae587b268104940122993243 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > dcb932e63d3419745c2b468845f3a4ec02e4552e > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > b1deb0753fe36d2908ed4c8a98178a93644fab64 > > lens-server/src/main/java/org/apache/lens/server/rewrite/CubeKeywordRemover.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java > abec2b338e0da6b56934a02d16c48a6a7917845a > > lens-server/src/main/java/org/apache/lens/server/rewrite/UserQueryToCubeQueryRewriter.java > 35de4d7ecdeb3575ea729fccab4da8824cef2344 > > lens-server/src/test/java/org/apache/lens/server/rewrite/CubeKeywordRemoverTest.java > PRE-CREATION > lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java > 202db822f41fc53e6dad8789d6cac62a8c9be68c > > Diff: https://reviews.apache.org/r/42022/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
