> On Jan. 13, 2016, 7:29 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, > > line 134 > > <https://reviews.apache.org/r/42022/diff/2/?file=1186196#file1186196line134> > > > > Can you check this with Hive 2.1 and see if we have to remove > > isCubeNode fully ? > > Rajat Khandelwal wrote: > Yes. As in we don't *need* to remove it, but the function will never > return true with Hive >= 2.1
It may not even generate AST with Hive 2.1, if the query has a cube keyword. We might have to do a replace "cube select " with "select ", even before generating AST. Please check. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42022/#review114156 ----------------------------------------------------------- On Jan. 7, 2016, 11:06 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42022/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 11:06 a.m.) > > > Review request for lens. > > > Bugs: LENS-912 > https://issues.apache.org/jira/browse/LENS-912 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e7550ca2c8307cba086e848e8b476a670366f7a5 > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java > abec2b338e0da6b56934a02d16c48a6a7917845a > lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java > 202db822f41fc53e6dad8789d6cac62a8c9be68c > > Diff: https://reviews.apache.org/r/42022/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
