> On Dec. 3, 2014, 4:14 a.m., Amareshwari Sriramadasu wrote: > > I'm surprised no changes are done in test code. Mostly because tests are > > running with single partition column tables? > > > > Expected query in tests testFactsWithTimedDimension would need change with > > these changes.
Yup. Must be. Already made those changes. Oh, I think I didn't upload the new diff. Uploading it now. Still only a few test classes need changes, that too in a few places. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28555/#review63643 ----------------------------------------------------------- On Dec. 3, 2014, 5:21 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28555/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 5:21 a.m.) > > > Review request for lens. > > > Bugs: LENS-33 > https://issues.apache.org/jira/browse/LENS-33 > > > Repository: lens > > > Description > ------- > > LENS-33: Latest partitions from fact tables should be skipped on the final > query > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > ad6d3fb > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 2409db8 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 0070ec2 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 88a1b7d > lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java > a7819c1 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java > 8b4756f > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 01cfcf7 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 485ff46 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > e24e0bc > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 1286d4f > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 17ae4c0 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > ee6f00f > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > 173c458 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 114bbc4 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java > 2661380 > > Diff: https://reviews.apache.org/r/28555/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [37.262s] > [INFO] Lens .............................................. SUCCESS [5:52.058s] > [INFO] Lens API .......................................... SUCCESS [1:13.315s] > [INFO] Lens API for server and extensions ................ SUCCESS [21.899s] > [INFO] Lens Cube ......................................... SUCCESS [7:19.968s] > [INFO] Lens DB storage ................................... SUCCESS [15.891s] > [INFO] Lens Query Library ................................ SUCCESS [7.291s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:41.192s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [5.694s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [31.473s] > [INFO] Lens Server ....................................... SUCCESS > [15:37.532s] > [INFO] Lens client ....................................... SUCCESS [22.020s] > [INFO] Lens CLI .......................................... SUCCESS [4:19.125s] > [INFO] Lens Examples ..................................... SUCCESS [1.896s] > [INFO] Lens Distribution ................................. SUCCESS [14.368s] > [INFO] Lens Client Distribution .......................... SUCCESS [7.319s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:43.040s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 42:37.651s > [INFO] Finished at: Tue Dec 02 23:58:59 IST 2014 > [INFO] Final Memory: 120M/625M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
