> On Dec. 15, 2014, 8:59 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 790 > > <https://reviews.apache.org/r/29035/diff/1/?file=791618#file791618line790> > > > > This is right now causing the entry for query being lost.We should look > > at the cause of exception and accordingly do retries or drop.If it is a > > valid db issue, then we end dropping all query entries. > > Rajat Khandelwal wrote: > In the code we can't know right know what problems might be occuring. We > can just increment error counters etc and hope those are looked at frequently. > > Amareshwari Sriramadasu wrote: > We need to look at what all the causes can be before dropping, otherwise > i feel current code is good enough which is retrying one insertion.
What I was going for was to do an exponential backoff and if too many failures, send a mail to maintainers so they can look at the issue, hopefully before max retries are done. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29035/#review65078 ----------------------------------------------------------- On Jan. 9, 2015, 7:35 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29035/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 7:35 a.m.) > > > Review request for lens. > > > Bugs: LENS-120 > https://issues.apache.org/jira/browse/LENS-120 > > > Repository: lens > > > Description > ------- > > QueryPurger Should retry with a timeout if db connection is not working. Also > There should be a limit to number of timeouts > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0ae539e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryPurgeFailed.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 9521136 > > Diff: https://reviews.apache.org/r/29035/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
