----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29035/#review67608 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java <https://reviews.apache.org/r/29035/#comment111666> Comment is not complete lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java <https://reviews.apache.org/r/29035/#comment111672> The config should be server level config. Not query level. Also update lensserver-default xml and apt files. lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryPurgeFailed.java <https://reviews.apache.org/r/29035/#comment111667> Why is server conf required? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/29035/#comment111668> Move the variable to QueryPurger? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/29035/#comment111669> Seems startTime is not query startTime, Can we name it appropriately? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/29035/#comment111670> One thing that I still have concern is - if the cause is because of DB issue, we are dropping the queries after timeout and raise event for each query lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/29035/#comment111671> Can we add a metric FinishedQueryDBInsertionError sothat alerts can set on top that? - Amareshwari Sriramadasu On Jan. 9, 2015, 7:35 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29035/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 7:35 a.m.) > > > Review request for lens. > > > Bugs: LENS-120 > https://issues.apache.org/jira/browse/LENS-120 > > > Repository: lens > > > Description > ------- > > QueryPurger Should retry with a timeout if db connection is not working. Also > There should be a limit to number of timeouts > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0ae539e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryPurgeFailed.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 9521136 > > Diff: https://reviews.apache.org/r/29035/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
