----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29881/#review68228 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java <https://reviews.apache.org/r/29881/#comment112375> Move the !isConstantsUsed(exprAST, false)) here to avoid in both if and else? lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java <https://reviews.apache.org/r/29881/#comment112378> We might have to return false for TABLE_OR_COL also? lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java <https://reviews.apache.org/r/29881/#comment112376> Simple return false? lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java <https://reviews.apache.org/r/29881/#comment112377> Can you add more fields like column +100, boolean constants like true, NULL and etc ? - Amareshwari Sriramadasu On Jan. 14, 2015, 11:29 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29881/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 11:29 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-131 > https://issues.apache.org/jira/browse/LENS-131 > > > Repository: lens > > > Description > ------- > > When constants get projected the queries by default they were being added to > group by. Such queries fail with No Such Column error. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 2531c49 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > cb70b66 > > Diff: https://reviews.apache.org/r/29881/diff/ > > > Testing > ------- > > Tested with queries with different types of constants projected and rewriter > skipping them in group by. Added unit test for the same. > > > Thanks, > > Sushil Mohanty > >
