> On Jan. 15, 2015, 9:35 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, > > line 23 > > <https://reviews.apache.org/r/29881/diff/1/?file=820874#file820874line23> > > > > All the imports can be clubbed together with `*`
What is the criteria for using * vs expanded import? I dont think we put any hard rules around it right now, which causing this to and fro across multiple patches. Will create jira to decide on and update contributor doc with same - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29881/#review68229 ----------------------------------------------------------- On Jan. 14, 2015, 11:29 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29881/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 11:29 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-131 > https://issues.apache.org/jira/browse/LENS-131 > > > Repository: lens > > > Description > ------- > > When constants get projected the queries by default they were being added to > group by. Such queries fail with No Such Column error. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 2531c49 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > cb70b66 > > Diff: https://reviews.apache.org/r/29881/diff/ > > > Testing > ------- > > Tested with queries with different types of constants projected and rewriter > skipping them in group by. Added unit test for the same. > > > Thanks, > > Sushil Mohanty > >
