> On Jan. 20, 2015, 7:04 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, > > line 577 > > <https://reviews.apache.org/r/29881/diff/2/?file=824925#file824925line577> > > > > Why are we putting NULL and TRUE in quotes? Arent they becoming strings > > with quotes?
NULL projected as column gives parsing error. Booleans work fine. - Sushil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29881/#review68696 ----------------------------------------------------------- On Jan. 19, 2015, 7:24 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29881/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 7:24 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-131 > https://issues.apache.org/jira/browse/LENS-131 > > > Repository: lens > > > Description > ------- > > When constants get projected the queries by default they were being added to > group by. Such queries fail with No Such Column error. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 2531c49 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > cb70b66 > > Diff: https://reviews.apache.org/r/29881/diff/ > > > Testing > ------- > > Tested with queries with different types of constants projected and rewriter > skipping them in group by. Added unit test for the same. > > > Thanks, > > Sushil Mohanty > >
