> On Jan. 15, 2015, 10:16 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, > > line 112 > > <https://reviews.apache.org/r/29881/diff/1/?file=820873#file820873line112> > > > > We might have to return false for TABLE_OR_COL also?
HiveParser.TOK_FUNCTION will be good enough for the single row functions(input one row and output one row) like case, foramt etc used on columns. Columns with out function will be added to to "group by" by default. Test query "hqlQuery2" has both column and function. - Sushil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29881/#review68228 ----------------------------------------------------------- On Jan. 14, 2015, 11:29 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29881/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 11:29 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-131 > https://issues.apache.org/jira/browse/LENS-131 > > > Repository: lens > > > Description > ------- > > When constants get projected the queries by default they were being added to > group by. Such queries fail with No Such Column error. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 2531c49 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > cb70b66 > > Diff: https://reviews.apache.org/r/29881/diff/ > > > Testing > ------- > > Tested with queries with different types of constants projected and rewriter > skipping them in group by. Added unit test for the same. > > > Thanks, > > Sushil Mohanty > >
