----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35589/#review88735 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java (line 44) <https://reviews.apache.org/r/35589/#comment141314> parent_dir | |__ a_dir | | | |__ jar_1 | | | |__ jar_2 | | | |__ jar_order(*1\n*2) | |__ b_dir | | | |__ jar_3 | | | |__ jar_4 | | | |__ glob_order(*4\n*3) | |__ c_dir | | | |__ jar_5 | | | |__ jar_6 | |__ jar_order(a*\nb*\nc*) new ScannedPaths("parent_*") Will this work? lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java (line 85) <https://reviews.apache.org/r/35589/#comment141312> Don't need to have return values for functions `removeDirs`, `filterByJarType`. They are taking a collection and modifying itself. - Rajat Khandelwal On June 21, 2015, 8:41 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35589/ > ----------------------------------------------------------- > > (Updated June 21, 2015, 8:41 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Add jar should be able to take regex path and should be able to add multiple > jars. > > https://issues.apache.org/jira/browse/LENS-513 > > New review comments for reopened jira. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 15a8e06 > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > ac773fe > lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java > 5073634 > > Diff: https://reviews.apache.org/r/35589/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
