> On June 22, 2015, 6:23 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java, > > line 160 > > <https://reviews.apache.org/r/35589/diff/2/?file=989046#file989046line160> > > > > Instead of this, let's go for something like this: > > > > > > https://github.com/apache/incubator-lens/blob/master/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java#L2539
Fixed. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35589/#review88736 ----------------------------------------------------------- On June 22, 2015, 11:31 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35589/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 11:31 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Add jar should be able to take regex path and should be able to add multiple > jars. > > https://issues.apache.org/jira/browse/LENS-513 > > New review comments for reopened jira. > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > ac773fe > lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java > 5073634 > > Diff: https://reviews.apache.org/r/35589/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
