----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35589/#review88770 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java (line 76) <https://reviews.apache.org/r/35589/#comment141356> Do we need an `exists` check before `isFile` and `isDir`? lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java (line 131) <https://reviews.apache.org/r/35589/#comment141355> Can you make sure when a non-existant non-regex path is provided, `ScannedPaths` doesn't break. lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java (line 154) <https://reviews.apache.org/r/35589/#comment141354> Let's keep this logic outside of `ScannedPaths`. the resource can take care of this, ScannedPaths can be a separate entity. - Rajat Khandelwal On June 22, 2015, 5:01 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35589/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 5:01 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Add jar should be able to take regex path and should be able to add multiple > jars. > > https://issues.apache.org/jira/browse/LENS-513 > > New review comments for reopened jira. > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > ac773fe > lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java > 5073634 > > Diff: https://reviews.apache.org/r/35589/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
