> On June 22, 2015, 12:13 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, > > line 87 > > <https://reviews.apache.org/r/35589/diff/3/?file=989667#file989667line87> > > > > Do we need an `exists` check before `isFile` and `isDir`?
Added ! > On June 22, 2015, 12:13 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, > > line 156 > > <https://reviews.apache.org/r/35589/diff/3/?file=989667#file989667line156> > > > > Can you make sure when a non-existant non-regex path is provided, > > `ScannedPaths` doesn't break. Added new testcase. > On June 22, 2015, 12:13 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, > > line 186 > > <https://reviews.apache.org/r/35589/diff/3/?file=989667#file989667line186> > > > > Let's keep this logic outside of `ScannedPaths`. the resource can take > > care of this, ScannedPaths can be a separate entity. Done. Moved back to sessionresource. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35589/#review88770 ----------------------------------------------------------- On June 22, 2015, 1 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35589/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 1 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Add jar should be able to take regex path and should be able to add multiple > jars. > > https://issues.apache.org/jira/browse/LENS-513 > > New review comments for reopened jira. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 4d82a06 > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > ac773fe > lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java > 5073634 > > Diff: https://reviews.apache.org/r/35589/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
