Thanks Leo. I was using Java 8 with maven 3 in a Linux VM. I don’t think maven 3 runs on Java 6.
Ralph > On Dec 23, 2021, at 5:11 AM, Leo Simons <m...@leosimons.com> wrote: > > On Thu, 23 Dec 2021 at 12:39, Ralph Goers <ralph.go...@dslextreme.com> > wrote: > >> It is still the middle of the night for me so I won’t do anything for >> several hours. > > > Whoa, best get some rest! :) > > I will create the branch but I am curious about the rest. When I ran the >> build last night it ran through a bunch of unit tests without any problems. > > > The 1.2.17 build as-is has only a short whitelist of tests being run from > maven. There are many more tests only set up to run with ant, without maven > invoking ant. > > I changed the maven build to run all tests. Then set up a matrix build. > Some of the other tests worked out of the box, not all. So then fixed the > tests that didn’t work with maven (or JDK 9, or Linux and JDK 11). Disabled > a couple really flaky ones. > > It then failed due to javadoc errors. > > > Probably you used JDK9+ where some warnings become errors. I fixed that too > in a later commit by fixing the javadoc. You can also use older JDK (IIRC 6 > or 7). > > I just told the plugin not to fail and then it started executing the site >> plugin. I tried updating the version but that just caused it to have an >> error in the site.xml. > > > Yup, fixing the site was a lot of work! > > My question is, you said that the build has test failures. Did I not see >> them because of the changes after 1.2.17 or is something else going on? > > > I think the summary answer here is “lots is going on”! > 1.2.17 partially migrated the build from ant to maven 2, back in 2012. > Frankly it wasn’t in so clean a state at time of release. > That makes sense since all the plug-in stability in maven really only came > after maven 3. Back then it was pretty normal to work around plugin > regressions every point release…you can see TODO comments in the 1.2.17 pom > about it… > ….you may have forgotten the extent of such pain :-). Cleaning it all up > was a bunch of explorative surgery! > > Cheers, > > Leo
