[
https://issues.apache.org/jira/browse/SOLR-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006901#comment-16006901
]
Hoss Man commented on SOLR-10572:
---------------------------------
wait a minute -- the {{mergePolicy}} warning may date back to 2012, but the
code to parse & use a {{mergePolicy}} declaration if it exists is still in the
6x code (and for that matter master too)
we shouldn't be removing the {{assertWarnOrFail}} call until *AFTER* the
functionality is removed ... that's the entire point of that method: while the
functionality is still supported (but deprecated) it can warn, once the
functionality is removed it can fail.
As things stand right now, if 7.0 is released tomorow someone with an old
config (who may not have ever noticed the warnings in past versions, or may
upgraded to 7.0 from a version before we deprecated that syntax) won't get a
warning about their {{mergePolicy}} config usage at all -- but in some future
version it will just silently stop working.
> (from 7.0.0 onwards) remove three no-longer-supported warnings in
> SolrIndexConfig
> ---------------------------------------------------------------------------------
>
> Key: SOLR-10572
> URL: https://issues.apache.org/jira/browse/SOLR-10572
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: SOLR-10572.patch
>
>
> The mergeScheduler, mergePolicy and luceneAutoCommit [no-longer-supported
> warnings|https://github.com/apache/lucene-solr/blame/48ca9fc3f4f8d95293cee7bb59eff61247ede181/solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java#L130-L140]
> date back to
> [2012|https://github.com/apache/lucene-solr/commit/058179d177208450850c5e3e3103710cadd3b53e].
> Let's remove them from 7.0.0 onwards for clarity. This caught my attention
> as part of SOLR-8668's mergePolicy support removal.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
