[
https://issues.apache.org/jira/browse/SOLR-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008340#comment-16008340
]
Hoss Man commented on SOLR-10572:
---------------------------------
bq. The removal of the <mergePolicy> warning would be included in the SOLR-8668
effort then instead, right? And the other two warnings would stay for now.
[~cpoerschke]: I haven't looked closely at the other two to know when they are
safe to remove -- i just noticed that removingthe mergePolicy warning was weird
since hte functionality itself doesn't seem to have been removed.
to be clear: the call to {{assertWarnOrFail}} should be removed many versions
_AFTER_ the functionality is removed -- the only change should be in the final
argument to the call, so that instead of logging a warning "don't do X use Y
instead" it triggers a hard failure with the message "don't do X use Y instead"
----
The method was designed so that the final boolean "failCondition" could be
something conditional -- like comparing some constant with the Version.LATEST
(of the luceneMatchVersion from the users config) -- so that you could write a
single line of code on master, backport it to a stable branch, and get a "fail"
on master but a "warn" on older branches (or better: a warn if their
luceneMatchVersion < X, but when they edit or replace their config and use a
newer luceneMatchVersion the warning becomes a fail) ... then we don't have to
go out of our way to remember when it's safe to remove an {{assertWarnOrFail}}
method call -- we just remove it completley once whatever Version constants it
refers to are removed (ie: 6.6 removed in 8.0)
> (from 7.0.0 onwards) remove three no-longer-supported warnings in
> SolrIndexConfig
> ---------------------------------------------------------------------------------
>
> Key: SOLR-10572
> URL: https://issues.apache.org/jira/browse/SOLR-10572
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-10572.patch
>
>
> The mergeScheduler, mergePolicy and luceneAutoCommit [no-longer-supported
> warnings|https://github.com/apache/lucene-solr/blame/48ca9fc3f4f8d95293cee7bb59eff61247ede181/solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java#L130-L140]
> date back to
> [2012|https://github.com/apache/lucene-solr/commit/058179d177208450850c5e3e3103710cadd3b53e].
> Let's remove them from 7.0.0 onwards for clarity. This caught my attention
> as part of SOLR-8668's mergePolicy support removal.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
