[ 
https://issues.apache.org/jira/browse/SOLR-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008485#comment-16008485
 ] 

Hoss Man commented on SOLR-10572:
---------------------------------

Oh man ... I'm sorry -- i totally missed the distinction. (and the fact that 
this line ends with {{true);}} ... not sure why it was ever written that way?)

bq. ... it is clearest to leave the code-as, hence the reverted commit.

I'm going to stop assuming I know what i'm talking about and trust you on this 
-- but i have to ask: isn't {{<mergePolicy class="myclass">...</mergePolicy>}} 
already deprecated though?  Shouldn't this (effectively) automatic failure if 
{{<mergePolicy>myclass</mergePolicy>}} is found be telling people to use 
{{mergePolicyFactory}} ?

> (from 7.0.0 onwards) remove three no-longer-supported warnings in 
> SolrIndexConfig
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-10572
>                 URL: https://issues.apache.org/jira/browse/SOLR-10572
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-10572.patch
>
>
> The mergeScheduler, mergePolicy and luceneAutoCommit [no-longer-supported 
> warnings|https://github.com/apache/lucene-solr/blame/48ca9fc3f4f8d95293cee7bb59eff61247ede181/solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java#L130-L140]
>  date back to 
> [2012|https://github.com/apache/lucene-solr/commit/058179d177208450850c5e3e3103710cadd3b53e].
>  Let's remove them from 7.0.0 onwards for clarity. This caught my attention 
> as part of SOLR-8668's mergePolicy support removal.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to