[
https://issues.apache.org/jira/browse/SOLR-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008419#comment-16008419
]
Christine Poerschke commented on SOLR-10572:
--------------------------------------------
Thanks for the detailed explanation!
At the risk of confusing things further and from just looking at this again
now, the code that I was trying to get rid of was
{code}
assertWarnOrFail("The <mergePolicy>myclass</mergePolicy> syntax is no longer
supported in solrconfig.xml. Please use syntax <mergePolicy class=\"myclass\"/>
instead.",
!((solrConfig.getNode(prefix + "/mergePolicy", false) != null) &&
(solrConfig.get(prefix + "/mergePolicy/@class", null) == null)),
true);
{code}
which is actually for functionality already no longer supported.
However since {{<mergePolicy class="myclass">...</mergePolicy>}} is still
supported at present and since the difference between {{class="myclass"}}
attribute and {{<mergePolicy>myclass</mergePolicy>}} element is very subtle
then it is clearest to leave the code-as, hence the reverted commit.
> (from 7.0.0 onwards) remove three no-longer-supported warnings in
> SolrIndexConfig
> ---------------------------------------------------------------------------------
>
> Key: SOLR-10572
> URL: https://issues.apache.org/jira/browse/SOLR-10572
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-10572.patch
>
>
> The mergeScheduler, mergePolicy and luceneAutoCommit [no-longer-supported
> warnings|https://github.com/apache/lucene-solr/blame/48ca9fc3f4f8d95293cee7bb59eff61247ede181/solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java#L130-L140]
> date back to
> [2012|https://github.com/apache/lucene-solr/commit/058179d177208450850c5e3e3103710cadd3b53e].
> Let's remove them from 7.0.0 onwards for clarity. This caught my attention
> as part of SOLR-8668's mergePolicy support removal.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
