+1 to remove the name of the pusher from the changelog Le mar. 5 juin 2018 à 06:29, Erick Erickson <erickerick...@gmail.com> a écrit :
> Robert: > > I don't have strong feelings either way. Personally I use "via" to > indicate that I didn't have much to do with the hard parts, I just was > the "committer fingers". If I've been more involved I just add my name > as a co-contributor (last). Basically it's a question of "how much > credit do I think I deserve?". If very little I use "via". If I'm more > involved, I just add a comma and my name. > > But that's a nuance that I suppose varies by person, so I'm happy > either way. Your point that the tighter integration with Git is well > taken, we can trace things back to whoever committed things pretty > easily. > > I'm -1 to having to remember to go to another place like a Wiki page, > too easy to forget. And I don't think we really need it. > > Erick > > > On Mon, Jun 4, 2018 at 5:47 PM, Robert Muir <rcm...@gmail.com> wrote: > > I raised this issue a few years ago, and no consensus was reached [1] > > > > I'm asking if we can take the time to revisit the issue. Back then it > > was subversion days, and you had "patch-uploaders" and "contributors". > > With git now, I believe the situation is even a bit more extreme, > > because the committer is the contributor and the lucene "committer" > > was really the "pusher". > > > > On the other hand, there were some reasons against removing this > > before. In particular some mentioned that it conveyed meaning about > > who might be the best person to ping about a particular area of the > > code. If this is still the case, I'd ask that we discuss alternative > > ways that it could be accomplished (such as wiki page perhaps > > linked-to HowToContribute that ppl can edit). > > > > I wrote a new summary/argument inline, but see the linked thread for > > the previous discussion: > > > > > > In the past CHANGES.txt entries from a contributor have also had the > > name of the committer with a 'via' entry. > > > > e.g.: > > > > LUCENE-1234: optimized FooBar. (Jane Doe via Joe Schmoe). > > > > I propose we stop adding the committer name (via Joe Schmoe). It seems > > to diminish the value of the contribution. It reminds me of a > > professor adding a second author by default or something like that. If > > someone really wants to know who committed the change, I think its > > fair that they look at version control history? > > > > 1. > http://mail-archives.apache.org/mod_mbox/lucene-dev/201206.mbox/%3CCAOdYfZW65MXrzyRPsvBD0C6c4X%2BLuQX4oVec%3DyR_PCPgTQrnhQ%40mail.gmail.com%3E > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > > For additional commands, e-mail: dev-h...@lucene.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > >