Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/438#discussion_r211817529
  
    --- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
    @@ -1146,6 +1146,11 @@
           <str>yyyy-MM-dd HH:mm[:ss[.SSS]][z</str>
           <str>yyyy-MM-dd HH:mm[:ss[,SSS]][z</str>
           <str>yyyy-MM-dd</str>
    +      <str>EEE, dd MMM yyyy HH:mm:ss z</str>
    +      <str>EEEE, dd-MMM-yy HH:mm:ss z</str>
    +      <str>EEE MMM d HH:mm:ss yyyy</str>
    +      <str>EEE MMM d hh:mm:ss z yyyy</str>
    --- End diff --
    
    The "hh" is erroneous.  I'm surprised this even works; perhaps "lenient" 
allows os to get away with it?  I was hoping to keep the added patterns more 
minimal.  You recently added "parse-date-patterns-from-extract-contrib" to 
solrconfig-parsing-update-processor-chains which is a better guide.
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to